nmt: use bytes instead of list for send_message and send_periodic#674
Open
bizfsc wants to merge 3 commits into
Open
nmt: use bytes instead of list for send_message and send_periodic#674bizfsc wants to merge 3 commits into
bizfsc wants to merge 3 commits into
Conversation
Use the CanData type alias provided by python-can to properly describe the accepted types for message data. This better matches the parameter description in the docstring, which specifically does *not* require a bytes-like object.
Member
|
Why don't we just fix our type annotations on the sending functions? Added a commit to that effect. With the proper typing in our network module, none of these fixes are necessary. It aligns with the parameter docstring on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts only the nmt.py changes from #651, which covers a broader set of mypy fixes across multiple files. Once the changes here are merged, #651 can be closed, as everything but the test_od changes are covered by other PRs.
The python-can send_message and send_periodic APIs expect bytes, not list[int]. Passing a list is accepted at runtime by some backends but is incorrect according to the type signatures and triggers Pylance and mypy errors. Using bytes literals and bytes() constructor makes the intent explicit and removes the type errors without any behavioral change.